Re: Tips on committing - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Tips on committing
Date
Msg-id b745e9af-2142-3324-05d0-6797f0f427d3@2ndquadrant.com
Whole thread Raw
In response to Re: Tips on committing  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 23/07/2018 05:58, Tom Lane wrote:
> 013f320dc reminds me of something I check for religiously: look for
> alternative output files for any regression test you're updating the
> output of.
> 
> Actually updating said files, once you notice you need to, can be tricky
> in itself.  Most of the time it works to just apply the same patch to the
> other variants as the delta you're observing for the output file that's
> relevant to your own platform.  Or you may be able to change configuration
> so as to replicate the correct output for another alternative file.  But
> sometimes you just have to guess (and then watch the buildfarm to see if
> you guessed right).

There is a recipe for doing this using the "merge" command here:
https://wiki.postgresql.org/wiki/Regression_test_authoring#Updating_an_existing_regression_test

YMMV

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Julian Markwort
Date:
Subject: Re: [PATCH] pg_hba.conf : new auth option : clientcert=verify-full
Next
From: Fabien COELHO
Date:
Subject: Re: Usability fail with psql's \dp command