Re: Tips on committing - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Tips on committing
Date
Msg-id 20298.1532318338@sss.pgh.pa.us
Whole thread Raw
In response to Re: Tips on committing  (Noah Misch <noah@leadboat.com>)
Responses Re: Tips on committing  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Re: Tips on committing  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Noah Misch <noah@leadboat.com> writes:
> I agree we won't all want the exact same checklist.  Still, it wouldn't hurt
> to have a wiki page of checklist entry ideas from which folks cherry-pick the
> entries they like.

013f320dc reminds me of something I check for religiously: look for
alternative output files for any regression test you're updating the
output of.

Actually updating said files, once you notice you need to, can be tricky
in itself.  Most of the time it works to just apply the same patch to the
other variants as the delta you're observing for the output file that's
relevant to your own platform.  Or you may be able to change configuration
so as to replicate the correct output for another alternative file.  But
sometimes you just have to guess (and then watch the buildfarm to see if
you guessed right).

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Get Columns from Plan
Next
From: Tom Lane
Date:
Subject: Re: Non-portable shell code in pg_upgrade tap tests