Re: Improper use about DatumGetInt32 - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Improper use about DatumGetInt32
Date
Msg-id b73c7919-a311-6cf5-aed6-bf2cd8641c52@enterprisedb.com
Whole thread Raw
In response to Re: Improper use about DatumGetInt32  (Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>)
Responses Re: Improper use about DatumGetInt32  (Anastasia Lubennikova <a.lubennikova@postgrespro.ru>)
Re: Improper use about DatumGetInt32  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
I have committed 0003.

For 0001, normal_rand(), I think you should reject negative arguments 
with an error.

For 0002, I think you should change the block number arguments to int8, 
same as other contrib modules do.



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: PATCH: Batch/pipelining support for libpq
Next
From: "David G. Johnston"
Date:
Subject: Re: [patch] [doc] Clarify that signal functions have no feedback