Re: patch: fix to use ``pg_get_functiondef()`` - Mailing list pgadmin-hackers

From Andrej Antonov
Subject Re: patch: fix to use ``pg_get_functiondef()``
Date
Msg-id b6449f1093463ef4820c5e1ddd5a21a9@imp-m.ru
Whole thread Raw
In response to Re: patch: fix to use ``pg_get_functiondef()``  (Dmitriy Olshevskiy <olshevskiy87@bk.ru>)
Responses Re: patch: fix to use ``pg_get_functiondef()``  (Andrej Antonov <antonov@imp-m.ru>)
List pgadmin-hackers
thank you, Dmitriy. I agree -- this-fix should works better.

I applyed this-fix to my local-git-branches ("REL-1_20_0-impulsm" and
"fix-to-use-pg_get_functiondef"). works good.

Dmitriy Olshevskiy писал 2015-12-13 18:04:
> Hi, Andrej!
>  Here is small fix of your patch - can you check it please?
>  I think there must be wxwidgets function IsEmpty() instead of double
> negation,
>  because type of the variable is wxstring. Also I added the Trim()
> function before
>  check if function definition is empty or not.
>
> On 08.12.2015 11:50, Andrej Antonov wrote:
>
>> patch: fix to use ``pg_get_functiondef()`` [see attachment file]
>>
>> it is copy of pull-request
>> https://github.com/postgres/pgadmin3/pull/12 [1]
>>
>> thank you!
>
> --
> Dmitriy Olshevskiy
>
>
> Links:
> ------
> [1] https://github.com/postgres/pgadmin3/pull/12

--
Андрей Антонов,
инженер-программист отдела информационных технологий и программирования,
компания «Импульс М»



pgadmin-hackers by date:

Previous
From: Dmitriy Olshevskiy
Date:
Subject: Re: patch: fix to use ``pg_get_functiondef()``
Next
From: Dave Page
Date:
Subject: pgAdmin III commit: Update for RC1