Re: patch: fix to use ``pg_get_functiondef()`` - Mailing list pgadmin-hackers

From Andrej Antonov
Subject Re: patch: fix to use ``pg_get_functiondef()``
Date
Msg-id 4241af2d7143ab303f4d3ad2a5a2dff7@imp-m.ru
Whole thread Raw
In response to Re: patch: fix to use ``pg_get_functiondef()``  (Andrej Antonov <antonov@imp-m.ru>)
Responses Re: patch: fix to use ``pg_get_functiondef()``  (Dmitriy Olshevskiy <olshevskiy87@bk.ru>)
List pgadmin-hackers
small fix ( diff see here:
https://github.com/postgres-impulsm/pgadmin3/commit/72f381aa1964d5630f3ada44768bc562911102e9
)


if we using ``pg_get_functiondef(func_oid)`` --
   in this case -- no need to write additional ``ALTER FUNCTION ... = ...
;``.


Andrej Antonov писал 2015-12-14 10:51:
> thank you, Dmitriy. I agree -- this-fix should works better.
>
> I applyed this-fix to my local-git-branches ("REL-1_20_0-impulsm" and
> "fix-to-use-pg_get_functiondef"). works good.
>
> Dmitriy Olshevskiy писал 2015-12-13 18:04:
>> Hi, Andrej!
>>  Here is small fix of your patch - can you check it please?
>>  I think there must be wxwidgets function IsEmpty() instead of double
>> negation,
>>  because type of the variable is wxstring. Also I added the Trim()
>> function before
>>  check if function definition is empty or not.
>>
>> On 08.12.2015 11:50, Andrej Antonov wrote:
>>
>>> patch: fix to use ``pg_get_functiondef()`` [see attachment file]
>>>
>>> it is copy of pull-request
>>> https://github.com/postgres/pgadmin3/pull/12 [1]
>>>
>>> thank you!
>>
>> --
>> Dmitriy Olshevskiy
>>
>>
>> Links:
>> ------
>> [1] https://github.com/postgres/pgadmin3/pull/12

--
Андрей Антонов,
инженер-программист отдела информационных технологий и программирования,
компания «Импульс М»
Attachment

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Added the backgrid cell for bootstrap switch for repr
Next
From: Björn Harrtell
Date:
Subject: ]GTK 3