patch to disallow zero length paths in binary (minor bug fix) - Mailing list pgsql-patches

From Merlin Moncure
Subject patch to disallow zero length paths in binary (minor bug fix)
Date
Msg-id b42b73150712171217p7d8b9858n51d593146f43df82@mail.gmail.com
Whole thread Raw
Responses Re: patch to disallow zero length paths in binary (minor bug fix)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Hackers,

Following is a patch to force the path type not to accept a path with
zero points.  This appears to be illegal in the parser, but possible
when sending a well formed packed in binary with zero points.  The old
behavior was this:

ERROR:  floating-point exception
DETAIL:  An invalid floating-point operation was signaled. This probably
means an out-of-range result or an invalid operation, such as division
by zero.

now it should properly display the points out of range error

merlin
eSilo

Index: src/backend/utils/adt/geo_ops.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/backend/utils/adt/geo_ops.c,v
retrieving revision 1.97
diff -r1.97 geo_ops.c
1459c1459
<   if (npts < 0 || npts >= (int32) ((INT_MAX - offsetof(PATH, p[0]))
/ sizeof(Point)))
---
>   if (npts <= 0 || npts >= (int32) ((INT_MAX - offsetof(PATH, p[0])) / sizeof(Point)))

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Auto create (top level) directory for create tablespace
Next
From: Tom Lane
Date:
Subject: Re: patch to disallow zero length paths in binary (minor bug fix)