Re: recovery_target_action=pause with confusing hint - Mailing list pgsql-hackers

On 2020/03/10 2:27, Robert Haas wrote:
> On Mon, Mar 9, 2020 at 12:03 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>> I started the discussion about the topic very related to this.
>> I'm thinking to apply the change that Sergei proposes after applying
>> the patch I attached in this thread.
>> https://postgr.es/m/00c194b2-dbbb-2e8a-5b39-13f14048ef0a@oss.nttdata.com
> 
> I think it would be good to change the primary message, not just the hint.  e.g.
> 
> LOG: pausing at end of recovery
> HINT: Execute pg_wal_replay_resume() to promote.
> 
> vs.
> 
> LOG: recovery has paused
> HINT: Execute pg_wal_replay_resume() to continue.

Looks good to me.
Attached is the updated version of the patch.
This is based on Sergei's patch.

Regards,


-- 
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters