Re: Add table access method as an option to pgbench - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: Add table access method as an option to pgbench
Date
Msg-id alpine.DEB.2.22.394.2011260819410.2914231@pseudo
Whole thread Raw
In response to Re: Add table access method as an option to pgbench  (David Zhang <david.zhang@highgo.ca>)
Responses Re: Add table access method as an option to pgbench
List pgsql-hackers
Hello David,

> The previous patch was based on branch "REL_13_STABLE". Now, the attached new 
> patch v2 is based on master branch. I followed the new code structure using 
> appendPQExpBuffer to append the new clause "using TABLEAM" in a proper 
> position and tested. In the meantime, I also updated the pgbench.sqml file to 
> reflect the changes.

My 0.02€: I'm fine with the added feature.

The patch lacks minimal coverage test. Consider adding something to 
pgbench tap tests, including failures (ie non existing method).

The option in the help string is not at the right ab place.

I would merge the tableam declaration to the previous one with a extended 
comments, eg "tablespace and access method selection".

escape_tableam -> escaped_tableam ?

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Stronger safeguard for archive recovery not to miss data
Next
From: Michael Paquier
Date:
Subject: Re: ResourceOwner refactoring