Re: [PATCH] pgbench tap tests fail if the path contains a perlspecial character - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: [PATCH] pgbench tap tests fail if the path contains a perlspecial character
Date
Msg-id alpine.DEB.2.21.1901220945370.15365@lancre
Whole thread Raw
In response to Re: [PATCH] pgbench tap tests fail if the path contains a perlspecial character  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: [PATCH] pgbench tap tests fail if the path contains a perlspecial character
List pgsql-hackers
Hello Tom,

> I did a little bit of googling on this subject last night, and it
> seems that at least some people believe that the answer is to not
> use glob, period, but read the directory for yourself.
>
> As a short-term move to un-break the buildfarm, I'm just going to
> revert that patch altogether.
>
> We can reapply it once we've figured out how to do the glob part correctly.

Here is a proposal patch which:

  - works around pgbench command splitting on spaces,
    if postgres sources are in a strangely named directory…
    I tested within a directory named "pg .* dir".

  - works aroung "glob" lack of portability by reading the directory
    directly and filtering with a standard re (see list_files).

  - adds a few comments

  - removes a spurious i option on an empty re

-- 
Fabien.
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: index_build does not need its isprimary argument
Next
From: Darafei "Komяpa" Praliaskouski
Date:
Subject: Re: Allowing extensions to find out the OIDs of their member objects