Postgres Pro
Downloads
Home   >   mailing lists

index_build does not need its isprimary argument - Mailing list pgsql-hackers

From Michael Paquier
Subject index_build does not need its isprimary argument
Date
Msg-id 20190122080852.GB3873@paquier.xyz
Whole thread Raw
Responses Re: index_build does not need its isprimary argument  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
Hi all,

While working on REINDEX CONCURRENTLY, I have noticed that
index_build() does not need its argument isprimary.  Perhaps it is
not worth bothering, but for the REINDEX CONCURRENTLY business this
removes the need to open an index when triggering a concurrent
build.

The flag was introduced in 3fdeb189, but f66e8bf actually forgot to
finish the cleanup as index_update_stats() has simplified its
interface.

Are there any objections if I cleanup that stuff as per the attached?

Thanks,
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: "Imai, Yoshikazu"
Date:
Subject: RE: speeding up planning with partitions
Next
From: Fabien COELHO
Date:
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perlspecial character