Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] proposal: psql command \graw - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: [HACKERS] proposal: psql command \graw
Date
Msg-id alpine.DEB.2.20.1711092047030.4821@lancre
Whole thread Raw
In response to Re: [HACKERS] proposal: psql command \graw  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: [HACKERS] proposal: psql command \graw  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers
Tree view 
Hello Pavel,

> I hope so I fixed all mentioned issues.

Patch applies with a warning:
 > git apply ~/psql-graw-2.patch /home/fabien/psql-graw-2.patch:192: new blank line at EOF. + warning: 1 line adds
whitespaceerrors.
 

Otherwise it compiles. "make check" ok. doc gen ok.

Two spurious empty lines are added before StoreQueryTuple.

Doc: "If <literal>+</literal> is appended to the command name, a column 
names are displayed."

I suggest instead: "When <literal>+</literal> is appended, column names 
are also displayed."

ISTM that you can remove "force_column_header" and just set "tuple_only" 
to what you need, that is you do not need to change anything in function 
"print_unaligned_text".

-- 
Fabien.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: [HACKERS] Simplify ACL handling for large objects and removal ofsuperuser() checks
Next
From: Paul Ramsey
Date:
Subject: [HACKERS] Inlining functions with "expensive" parameters