Re: Test suite fails on non-default configuration - Mailing list pgsql-jdbc

From Kris Jurka
Subject Re: Test suite fails on non-default configuration
Date
Msg-id alpine.BSO.2.00.1104182127510.27592@leary.csoft.net
Whole thread Raw
In response to Re: Test suite fails on non-default configuration  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Test suite fails on non-default configuration  ("Kevin Grittner" <Kevin.Grittner@wicourts.gov>)
List pgsql-jdbc

On Mon, 18 Apr 2011, Tom Lane wrote:

> "Kevin Grittner" <Kevin.Grittner@wicourts.gov> writes:
>>         // PostgreSQL defaults to READ COMMITTED
>>         assertEquals(Connection.TRANSACTION_READ_COMMITTED,
>>                      con.getTransactionIsolation());
>
>> Should the unit tests really be failing based on configuration
>> options?
>
> Well, for a comparison point, you can certainly make the server's
> regression tests fail too if you whack the configuration around enough.
> I agree that the above seems perhaps overly fragile, but I don't think
> you can expect to have a general principle that the JDBC tests should
> pass regardless of configuration.  It's more a question of how painful
> is it to support any particular nondefault configuration choice, and
> does it seem worth it based on real-world usage of the choice.
>

Exactly.  In this case the tests were assuming too much for no real
purpose.  I've checked in a fix to work with any default isolation level.

Kris Jurka



pgsql-jdbc by date:

Previous
From: Kris Jurka
Date:
Subject: Re: [HACKERS] JDBC connections to 9.1
Next
From: Kris Jurka
Date:
Subject: New 9.1dev driver release