Postgres Pro
Downloads
Home   >   mailing lists

Re: Alter index rename concurrently to - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Alter index rename concurrently to
Date
Msg-id aa4b16af-5cca-ded6-f5fa-1a0dadcf5906@2ndquadrant.com
Whole thread Raw
In response to Re[2]: Alter index rename concurrently to  (Andrey Klychkov <aaklychkov@mail.ru>)
Responses Re[2]: Alter index rename concurrently to  (Andrey Klychkov <aaklychkov@mail.ru>)
Re: Alter index rename concurrently to  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Tree view 
On 03/10/2018 13:51, Andrey Klychkov wrote:
> 1. Patch was applied without any errors except a part related to
> documentation:
> error: patch failed: doc/src/sgml/ref/alter_index.sgml:50
> error: doc/src/sgml/ref/alter_index.sgml: patch does not apply

Attached is an updated patch.

> 2. The code has been compiled successfully, configured by:
> # ./configure CFLAGS="-O0" --enable-debug --enable-cassert
> --enable-depend --without-zlib

Not sure why you use -O0 here.  It's not a good idea for development,
because it might miss interesting warnings.

> 7. Code style:
> +RenameRelationInternal(Oid myrelid, const char *newrelname, bool
> is_internal, bool is_index)
> This line is longer than 80 chars.

pgindent leaves this line alone.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: Problem while updating a foreign table pointing to a partitionedtable on foreign server
Next
From: Etsuro Fujita
Date:
Subject: Re: Problems with plan estimates in postgres_fdw