Re: pgsql: Introduce pg_shmem_allocations_numa view - Mailing list pgsql-hackers

From Christoph Berg
Subject Re: pgsql: Introduce pg_shmem_allocations_numa view
Date
Msg-id aFu6tmQ7EVaaNV9K@msg.df7cb.de
Whole thread Raw
In response to Re: pgsql: Introduce pg_shmem_allocations_numa view  (Tomas Vondra <tomas@vondra.me>)
List pgsql-hackers
Re: Bertrand Drouvot
> +/*
> + * Work around Linux kernel bug in 32-bit compat mode: do_pages_stat() has
> + * incorrect pointer arithmetic for more than DO_PAGES_STAT_CHUNK_NR pages.
> + */
> +#if SIZEOF_SIZE_T == 4

I was also missing it in my suggested patch draft, but this should
probably include #ifdef __linux__.


Re: Tomas Vondra
> +#ifdef USE_VALGRIND
> +
> +static inline void
> +pg_numa_touch_mem_if_required(uint64 tmp, char *ptr)

Stupid question, if this function gets properly inlined, why not
always use it as there should be no performance difference vs using a
macro?

Christoph



pgsql-hackers by date:

Previous
From: Maxim Orlov
Date:
Subject: Re: Issue with custom operator in simple case
Next
From: Peter Eisentraut
Date:
Subject: Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.