Re: [PATCH] Proposal for HIDDEN/INVISIBLE column - Mailing list pgsql-hackers

From Gilles Darold
Subject Re: [PATCH] Proposal for HIDDEN/INVISIBLE column
Date
Msg-id a9150da6-503a-a5a2-a80e-9dedc63287db@migops.com
Whole thread Raw
In response to [PATCH] Proposal for HIDDEN/INVISIBLE column  (Gilles Darold <gilles@migops.com>)
Responses Re: [PATCH] Proposal for HIDDEN/INVISIBLE column  (Vik Fearing <vik@postgresfriends.org>)
Re: [PATCH] Proposal for HIDDEN/INVISIBLE column  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Hi,


Here is a new version of the patch for the hidden column feature with 
the following changes:


   - Rename the HIDDEN into UNEXPANDED and replace all references to 
hidden column into unexpanded column

   - Remove changes in the information_schema

   - Limit use of the UNEXPANDED attribute to ALTER COLUMN SET/DROP 
commands.

   - Add a check into SET UNEXPANDED code to verify that there is at 
least one column expanded.

   - Verify that INSERT INTO table SELECT * FROM table respect the 
unexpanded column feature.

   - Verify that RETURNING * clause also respect the unexpanded column 
feature.


I have kept the behavior on function using the wildcard * which does not 
take care of the unexpanded column attribute.


I have not though of other gotcha for the moment, I will update the 
patch if other cases come. In psql the Expended  information is 
displayed when using \d+, perhaps it could be better to see this 
information directly with \d so that the information comes to the eyes 
immediately.


-- 
Gilles Darold


Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Refactoring pg_dump's getTables()
Next
From: Vik Fearing
Date:
Subject: Re: [PATCH] Proposal for HIDDEN/INVISIBLE column