Re: REINDEX SCHEMA/DATABASE/SYSTEM weak with dropped relations - Mailing list pgsql-hackers

From Anastasia Lubennikova
Subject Re: REINDEX SCHEMA/DATABASE/SYSTEM weak with dropped relations
Date
Msg-id a63909b4-352b-d06a-5670-a6eba92223e9@postgrespro.ru
Whole thread Raw
In response to Re: REINDEX SCHEMA/DATABASE/SYSTEM weak with dropped relations  (Michael Paquier <michael@paquier.xyz>)
Responses Re: REINDEX SCHEMA/DATABASE/SYSTEM weak with dropped relations  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 01.09.2020 04:38, Michael Paquier wrote:
> I have added some extra comments.  There is one in
> ReindexRelationConcurrently() to mention that there should be no extra
> use of MISSING_OK once the list of indexes is built as session locks
> are taken where needed.
Great, it took me a moment to understand the logic around index list 
check at first pass.
> Does the version attached look fine to you?  I have done one round of
> indentation while on it.

Yes, this version is good.

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company




pgsql-hackers by date:

Previous
From: Michael Banck
Date:
Subject: [patch] Fix checksum verification in base backups for zero page headers
Next
From: Georgios
Date:
Subject: Re: Include access method in listTables output