Re: Increase psql's password buffer size - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Increase psql's password buffer size
Date
Msg-id a47b893c-4917-1a18-8f0a-27d1f15f8ab8@oss.nttdata.com
Whole thread Raw
In response to Re: Increase psql's password buffer size  (David Fetter <david@fetter.org>)
List pgsql-hackers

On 2020/01/22 9:41, David Fetter wrote:
> On Tue, Jan 21, 2020 at 07:05:47PM +0100, David Fetter wrote:
>> On Tue, Jan 21, 2020 at 10:23:59AM -0500, Bruce Momjian wrote:
>>> On Tue, Jan 21, 2020 at 04:19:13PM +0100, David Fetter wrote:
>>>> On Tue, Jan 21, 2020 at 10:12:52AM -0500, Bruce Momjian wrote:
>>>>> I think we should be using a macro to define the maximum length, rather
>>>>> than have 100 used in various places.
>>>>
>>>> It's not just 100 in some places. It's different in different places,
>>>> which goes to your point.
>>>>
>>>> How about using a system that doesn't meaningfully impose a maximum
>>>> length? The shell variable is a const char *, so why not just
>>>> re(p)alloc as needed?
>>>
>>> Uh, how do you know how big to make the buffer that receives the read?
>>
>> You can start at any size, possibly even 100, and then increase the
>> size in a loop along the lines of (untested)

That's possible, but I like having the (reasonable) upper limit on that
rather than arbitrary size.

Regards,

-- 
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Increase psql's password buffer size
Next
From: Amit Kapila
Date:
Subject: Re: [HACKERS] Block level parallel vacuum