Re: Increase psql's password buffer size - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Increase psql's password buffer size
Date
Msg-id 7c4d5916-afd5-df1a-f7d0-9817149efa50@oss.nttdata.com
Whole thread Raw
In response to Re: Increase psql's password buffer size  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Increase psql's password buffer size  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-hackers

On 2020/01/22 0:12, Bruce Momjian wrote:
> On Tue, Jan 21, 2020 at 02:42:07PM +0900, Fujii Masao wrote:
>> I have no strong opinion about the maximum length of password,
>> for now. But IMO it's worth committing that 0001 patch as the first step
>> for this problem.
>>
>> Also IMO the more problematic thing is that psql silently truncates
>> the password specified in the prompt into 99B if its length is
>> more than 99B. I think that psql should emit a warning in this case
>> so that users can notice that.
> 
> I think we should be using a macro to define the maximum length, rather
> than have 100 used in various places.

+1 as the first step for this issue. The patch that I mentioned
upthread actually does that.

Regards,

-- 
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters



pgsql-hackers by date:

Previous
From: Tatsuro Yamada
Date:
Subject: Re: progress report for ANALYZE
Next
From: Fujii Masao
Date:
Subject: Re: Increase psql's password buffer size