Re: Regression tests fail with musl libc because libpq.so can't be loaded - Mailing list pgsql-bugs

From walther@technowledgy.de
Subject Re: Regression tests fail with musl libc because libpq.so can't be loaded
Date
Msg-id a2463df1-be45-4a76-b90f-7676d778e7b1@technowledgy.de
Whole thread Raw
In response to Re: Regression tests fail with musl libc because libpq.so can't be loaded  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Regression tests fail with musl libc because libpq.so can't be loaded  (Bruce Momjian <bruce@momjian.us>)
List pgsql-bugs
Bruce Momjian:
> I suggest we use the #ifdef test to continue our existing behavior for
> the libraries we know about, like glibc, and use the LD_* process title
> truncation hack for libc's we don't recognize.
> 
> Attached is a prototype patch which implements this based on previous
> patches.

The condition to check for linux/glibc in your patch is slightly off:

   #if ! defined(__linux__) || (! defined(__GLIBC__) && 
defined(__UCLIBC__ ))

should be

   #if defined(__linux__) && ! (defined(__GLIBC__) || defined(__UCLIBC__ ))

With the latter, it passes tests with musl.

Best,

Wolfgang



pgsql-bugs by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Index plan returns different results to sequential scan
Next
From: Richard Guo
Date:
Subject: Re: BUG #18305: Unexpected error: "WindowFunc not found in subplan target lists" triggered by subqueries