Re: Add Information during standby recovery conflicts - Mailing list pgsql-hackers

Hi,

On 11/16/20 6:44 AM, Masahiko Sawada wrote:
> Thank you for updating the patch.
>
> Here are review comments.
>
> +           if (report_waiting && (!logged_recovery_conflict ||
> new_status == NULL))
> +               ts = GetCurrentTimestamp();
>
> The condition will always be true if log_recovery_conflict_wait is
> false and report_waiting is true, leading to unnecessary calling of
> GetCurrentTimestamp().
>
> ---
> +   <para>
> +    You can control whether a log message is produced when the startup process
> +    is waiting longer than <varname>deadlock_timeout</varname> for recovery
> +    conflicts. This is controled by the <xref
> linkend="guc-log-recovery-conflict-waits"/>
> +    parameter.
> +   </para>
>
> s/controled/controlled/
>
> ---
>      if (report_waiting)
>          waitStart = GetCurrentTimestamp();
>
> Similarly, we have the above code but we don't need to call
> GetCurrentTimestamp() if update_process_title is false, even if
> report_waiting is true.
>
> I've attached the patch that fixes the above comments. It can be
> applied on top of your v8 patch.

Thanks for the review and the associated fixes!

I've attached a new version that contains your fixes.

Thanks

Bertrand