Re: pg_dump --no-comments confusion - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pg_dump --no-comments confusion
Date
Msg-id Zzu6sE1OliI1Z5z5@momjian.us
Whole thread Raw
In response to Re: pg_dump --no-comments confusion  (Marcos Pegoraro <marcos@f10.com.br>)
List pgsql-hackers
On Mon, Nov 18, 2024 at 06:36:45PM -0300, Marcos Pegoraro wrote:
> But it would be good to have this patch applied to all supported versions, as
> soon as nothing was changed on that pg_dump option, no ?
> 
> Em seg., 18 de nov. de 2024 às 18:30, Bruce Momjian <bruce@momjian.us>
> escreveu:
> 
>     On Tue, Nov  5, 2024 at 10:12:20AM +0100, Álvaro Herrera wrote:
>     > On 2024-Nov-04, Erik Wienhold wrote:
>     >
>     > > I think Bruce's suggestion is pretty clear that it does not mean line
>     or
>     > > block comments, but rather the COMMENT command.  But I also think that
>     > > "SQL" in front of the command name is unnecessary [...]
>     >
>     > +1 for "Do not dump COMMENT commands", which is what I think you're
>     > saying.
> 
>     Patch applied to master.

Well, I have these notes about doc changes:

*  inaccuracies, apply to all applicable supported versions
*  missing docs, master and most recent major version
*  unclear language or major edits, master only

and it seems this patch matches the last one, which is why I only did
master.  Of course, these are just guidelines --- if people want me to,
I can apply it to all supported braches.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"



pgsql-hackers by date:

Previous
From: Marcos Pegoraro
Date:
Subject: Re: pg_dump --no-comments confusion
Next
From: Tom Lane
Date:
Subject: Re: pg_dump --no-comments confusion