Re: pg_dump --no-comments confusion - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_dump --no-comments confusion
Date
Msg-id 3495698.1731968093@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_dump --no-comments confusion  (Marcos Pegoraro <marcos@f10.com.br>)
List pgsql-hackers
Marcos Pegoraro <marcos@f10.com.br> writes:
> But it would be good to have this patch applied to all supported versions,
> as soon as nothing was changed on that pg_dump option, no ?

Even more to the point, should we change pg_dump's help output?

...
  --load-via-partition-root    load partitions via the root table
  --no-comments                do not dump comments
  --no-publications            do not dump publications
...

Also, the identical text appears in pg_dumpall's man page and help
output, while pg_restore has a differently worded version:

    printf(_("  --no-comments                do not restore comments\n"));

pg_restore's man page seems OK though:

        Do not output commands to restore comments, even if the archive
        contains them.

Note: I would not argue for back-patching changes in the help output,
as that creates translation issues.  So probably back-patching the
SGML changes isn't appropriate either.  But we should make all of this
consistent in master.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pg_dump --no-comments confusion
Next
From: Tom Lane
Date:
Subject: UNION versus collations