Re: Tab completion for "create unlogged" a bit too lax? - Mailing list pgsql-hackers

From Daniel Westermann (DWE)
Subject Re: Tab completion for "create unlogged" a bit too lax?
Date
Msg-id ZR0P278MB0920121BB3A0EF977F40FBBCD2C59@ZR0P278MB0920.CHEP278.PROD.OUTLOOK.COM
Whole thread Raw
In response to Re: Tab completion for "create unlogged" a bit too lax?  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: Tab completion for "create unlogged" a bit too lax?  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
>On Tue, Aug 24, 2021 at 11:32:14AM +0000, Daniel Westermann (DWE) wrote:
>> tab completion for "create unlogged" gives this:
>>
>> postgres=# create unlogged
>> MATERIALIZED VIEW  TABLE  
>>
>> Given that a materialized table can not be unlogged:
>>
>> postgres=# create unlogged materialized view mv1 as select 1;
>> ERROR:  materialized views cannot be unlogged
>>
>> Should this really show up there?

>It seems to be deliberate:

>commit 3223b25ff737c2bf4a642c0deb7be2b30bfecc6e
>Author: Tom Lane <tgl@sss.pgh.pa.us>
>Date:   Mon May 6 11:57:05 2013 -0400

>    Disallow unlogged materialized views.
>...
>    I left the grammar and tab-completion support for CREATE UNLOGGED
>    MATERIALIZED VIEW in place, since it's harmless and allows delivering a
>    more specific error message about the unsupported feature.

Hm, I think tab completion should only give choices for operations that are supposed to work. Anyway, thanks for
pointingme to the commit, that makes it more clear why it is that way. 

Regards
Daniel


pgsql-hackers by date:

Previous
From: Fabrízio de Royes Mello
Date:
Subject: Re: [GSoC 2021 project summary] PL/Julia
Next
From: Dipesh Pandit
Date:
Subject: Re: .ready and .done files considered harmful