Postgres Pro
Downloads
Home   >   mailing lists

Re: Move backup-related code to xlogbackup.c/.h - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Move backup-related code to xlogbackup.c/.h
Date
Msg-id Yz03Qff/pIIGL+EP@paquier.xyz
Whole thread Raw
In response to Re: Move backup-related code to xlogbackup.c/.h  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: Move backup-related code to xlogbackup.c/.h  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Re: Move backup-related code to xlogbackup.c/.h  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Tree view 
On Tue, Oct 04, 2022 at 03:54:20PM -0700, Nathan Bossart wrote:
> I would suggest moving this to a separate prerequisite patch that can be
> reviewed independently from the patches that simply move code to a
> different file.

And FWIW, the SQL interfaces for pg_backup_start() and
pg_backup_stop() could stay in xlogfuncs.c.  This has the advantage to
centralize in the same file all the SQL-function-specific checks.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Non-replayable WAL records through overflows and >MaxAllocSize lengths
Next
From: Alvaro Herrera
Date:
Subject: Re: Suppressing useless wakeups in walreceiver