Postgres Pro
Downloads
Home   >   mailing lists

Re: Move backup-related code to xlogbackup.c/.h - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Move backup-related code to xlogbackup.c/.h
Date
Msg-id 20221004225420.GB779730@nathanxps13
Whole thread Raw
In response to Move backup-related code to xlogbackup.c/.h  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Move backup-related code to xlogbackup.c/.h  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On Wed, Sep 28, 2022 at 08:16:08PM +0530, Bharath Rupireddy wrote:
> In doing so, I had to add a few Get/Set functions
> for XLogCtl variables so that xlogbackup.c can use them.

I would suggest moving this to a separate prerequisite patch that can be
reviewed independently from the patches that simply move code to a
different file.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Startup process on a hot standby crashes with an error "invalid memory alloc request size 1073741824" while replaying "Standby/LOCK" records
Next
From: Garen Torikian
Date:
Subject: Re: [PATCH] Expand character set for ltree labels