Re: Query Jumbling for CALL and SET utility statements - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Query Jumbling for CALL and SET utility statements
Date
Msg-id Yz+nUUVc3UtJtU6q@paquier.xyz
Whole thread Raw
In response to Re: Query Jumbling for CALL and SET utility statements  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Query Jumbling for CALL and SET utility statements  ("Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>)
List pgsql-hackers
On Thu, Oct 06, 2022 at 11:51:52PM -0400, Tom Lane wrote:
> I've been thinking since the beginning of this thread that there
> was no coherent, defensible rationale being offered for jumbling
> some utility statements and not others.

Yeah.  The potential performance impact of all the TransactionStmts
worries me a bit, though.

> I wonder if the answer is to jumble them all.  We avoided that
> up to now because it would imply a ton of manual effort and
> future code maintenance ... but now that the backend/nodes/
> infrastructure is largely auto-generated, could we auto-generate
> the jumbling code?

Probably.  One part that may be tricky though is the location of the
constants we'd like to make generic, but perhaps this could be handled
by using a dedicated variable type that just maps to int?  It does not
seem like a mandatory requirement to add that everywhere as a first
step, either.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: shadow variables - pg15 edition
Next
From: Julien Rouhaud
Date:
Subject: Re: Query Jumbling for CALL and SET utility statements