Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~ - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
Date
Msg-id YxmuDClnF90gAxxW@paquier.xyz
Whole thread Raw
In response to Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
List pgsql-hackers
On Tue, Aug 30, 2022 at 01:29:24PM +1200, Thomas Munro wrote:
> This reminds me of 24c3ce8f1, which replaced a dlopen()-ish thing with
> a direct function call.  Can you just call all these functions
> directly these days?

Hmm.  Some tests in the CI show that attempting to call directly
MiniDumpWriteDump() causes a linking failure at compilation.  Anyway,
in the same fashion, I can get some simplifications done right for
pg_ctl.c, auth.c and restricted_token.c.  And I am seeing all these
functions listed in the headers of MinGW, meaning that all these
should work out of the box in this case, no?

The others are library-dependent, and I not really confident about
ldap_start_tls_sA().  So, at the end, I am finishing with the
attached, what do you think?  This cuts some code, which is nice:
 3 files changed, 48 insertions(+), 159 deletions(-)
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "Anton A. Melnikov"
Date:
Subject: Re: [BUG] Logical replica crash if there was an error in a function.
Next
From: "Drouvot, Bertrand"
Date:
Subject: Re: [PATCH] Query Jumbling for CALL and SET utility statements