Re: broken regress tests on fedora 36 - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: broken regress tests on fedora 36
Date
Msg-id Yp9K4o31JHaLTXnZ@paquier.xyz
Whole thread Raw
In response to broken regress tests on fedora 36  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: broken regress tests on fedora 36
Re: broken regress tests on fedora 36
List pgsql-hackers
On Tue, Jun 07, 2022 at 10:52:45AM +0200, Pavel Stehule wrote:
> #   Failed test '\timing with query error: timing output appears'
> #   at t/001_basic.pl line 95.
> #                   'Time: 0,293 ms'
> #     doesn't match '(?^m:^Time: \d+\.\d\d\d ms)'
> # Looks like you failed 2 tests of 58.

Fun.  The difference is in the separator: dot vs comma.  This should
fail with French the same way.  Perhaps it would fail differently in
other languages?  There is no need to be that precise with the regex
IMO, so I would just cut the regex with the number, checking only the
unit at the end.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns
Next
From: Ian Lawrence Barwick
Date:
Subject: Re: docs: mention "pg_read_all_stats" in "track_activities" description