Re: broken regress tests on fedora 36 - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: broken regress tests on fedora 36
Date
Msg-id 044dd43b-f887-da7d-c7ca-423500caacf0@dunslane.net
Whole thread Raw
In response to Re: broken regress tests on fedora 36  (Michael Paquier <michael@paquier.xyz>)
Responses Re: broken regress tests on fedora 36
List pgsql-hackers
On 2022-06-07 Tu 08:56, Michael Paquier wrote:
> On Tue, Jun 07, 2022 at 10:52:45AM +0200, Pavel Stehule wrote:
>> #   Failed test '\timing with query error: timing output appears'
>> #   at t/001_basic.pl line 95.
>> #                   'Time: 0,293 ms'
>> #     doesn't match '(?^m:^Time: \d+\.\d\d\d ms)'
>> # Looks like you failed 2 tests of 58.
> Fun.  The difference is in the separator: dot vs comma.  This should
> fail with French the same way.  Perhaps it would fail differently in
> other languages?  There is no need to be that precise with the regex
> IMO, so I would just cut the regex with the number, checking only the
> unit at the end.


or just replace '\.' with '[.,]'


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: "Jonathan S. Katz"
Date:
Subject: Re: How about a psql backslash command to show GUCs?
Next
From: Tomas Vondra
Date:
Subject: Re: effective_io_concurrency and NVMe devices