Postgres Pro
Downloads
Home   >   mailing lists

Re: Assert name/short_desc to prevent SHOW ALL segfault - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Assert name/short_desc to prevent SHOW ALL segfault
Date
Msg-id Yo2/FfbtzTrwKgsM@paquier.xyz
Whole thread Raw
In response to Assert name/short_desc to prevent SHOW ALL segfault  (Steve Chavez <steve@supabase.io>)
List pgsql-hackers
Tree view 
On Wed, May 25, 2022 at 12:05:55AM -0500, Steve Chavez wrote:
> Thank you for the reviews Nathan, Michael.
>
> I agree with handling NULL in ShowAllGUCConfig() instead.
>
> I've attached the updated patch.

Shouldn't the same check as extra_desc be done in
GetConfigOptionByNum() for short_desc (point of upthread)?  See
3ac7d024, though -fsanitize=undefined does not apply here, I guess.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Steve Chavez
Date:
Subject: Re: Assert name/short_desc to prevent SHOW ALL segfault
Next
From: Andres Freund
Date:
Subject: Re: Assert name/short_desc to prevent SHOW ALL segfault