Postgres Pro
Downloads
Home   >   mailing lists

Assert name/short_desc to prevent SHOW ALL segfault - Mailing list pgsql-hackers

From Steve Chavez
Subject Assert name/short_desc to prevent SHOW ALL segfault
Date
Msg-id CAGRrpzY6hO-Kmykna_XvsTv8P2DshGiU6G3j8yGao4mk0CqjHA@mail.gmail.com
Whole thread Raw
Responses Re: Assert name/short_desc to prevent SHOW ALL segfault
List pgsql-hackers
Tree view
Hello hackers,

The DefineCustomStringVariable function(or any other DefineCustomXXXVariable) has a short_desc parameter that can be NULL and it's not apparent that this will lead to a segfault when SHOW ALL is used.
This happens because the ShowAllGUCConfig function expects a non-NULL short_desc.

This happened for the Supabase supautils extension(https://github.com/supabase/supautils/issues/24) and any other extension that uses the DefineCustomXXXVariable has the same bug risk.

This patch does an Assert on the short_desc(also on the name as an extra measure), so a postgres built with --enable-cassert can prevent the above issue.

---
Steve Chavez
Engineering at https://supabase.com/
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: partition wise aggregate wrong rows cost
Next
From: Jeff Janes
Date:
Subject: Re: PostgreSQL 15 Beta 1 release announcement draft