Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_stop_backup() v2 incorrectly marked as proretset - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_stop_backup() v2 incorrectly marked as proretset
Date
Msg-id Yh9BIWEcWVZJUQm1@paquier.xyz
Whole thread Raw
In response to Re: pg_stop_backup() v2 incorrectly marked as proretset  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: pg_stop_backup() v2 incorrectly marked as proretset  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
Tree view 
On Wed, Mar 02, 2022 at 05:22:35PM +0900, Kyotaro Horiguchi wrote:
> But the patch forgets to remove an useless variable.

Indeed.  I forgot to look at stderr.

>>    /* Initialise attributes information in the tuple descriptor */
>>    tupdesc = CreateTemplateTupleDesc(PG_STOP_BACKUP_V2_COLS);
>>    TupleDescInitEntry(tupdesc, (AttrNumber) 1, "lsn",
>>                       PG_LSNOID, -1, 0);
>
> I think we can use get_call_resuilt_type here.

Yes, I don't mind doing so here.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: create_index test fails when synchronous_commit = off @ master
Next
From: Dean Rasheed
Date:
Subject: Re: [PATCH] Add reloption for views to enable RLS