Re: Replacing TAP test planning with done_testing() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Replacing TAP test planning with done_testing()
Date
Msg-id YgRjM7fJkbIb5iTc@paquier.xyz
Whole thread Raw
In response to Re: Replacing TAP test planning with done_testing()  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Replacing TAP test planning with done_testing()
Re: Replacing TAP test planning with done_testing()
List pgsql-hackers
On Wed, Feb 09, 2022 at 02:49:47PM -0500, Tom Lane wrote:
> =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org> writes:
>> Daniel Gustafsson <daniel@yesql.se> writes:
>>> The attached patch removes all Test::More planning and instead ensures that all
>>> tests conclude with a done_testing() call.  While there, I also removed a few
>>> exit(0) calls from individual tests making them more consistent.
>
>> LGTM, +1.
>
> LGTM too.

Not tested, but +1.  Could it be possible to backpatch that even if
this could be qualified as only cosmetic?  Each time a test is
backpatched we need to tweak the number of tests planned, and that may
change slightly depending on the branch dealt with.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: row filtering for logical replication
Next
From: Michael Paquier
Date:
Subject: Re: Justin Pryzby