At Thu, 10 Feb 2022 09:58:27 +0900, Michael Paquier <michael@paquier.xyz> wrote in
> On Wed, Feb 09, 2022 at 02:49:47PM -0500, Tom Lane wrote:
> > =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org> writes:
> >> Daniel Gustafsson <daniel@yesql.se> writes:
> >>> The attached patch removes all Test::More planning and instead ensures that all
> >>> tests conclude with a done_testing() call. While there, I also removed a few
> >>> exit(0) calls from individual tests making them more consistent.
> >
> >> LGTM, +1.
> >
> > LGTM too.
+1. I was anoyed by the definitions especially when adding Non-windows
only tests.
> Not tested, but +1. Could it be possible to backpatch that even if
> this could be qualified as only cosmetic? Each time a test is
> backpatched we need to tweak the number of tests planned, and that may
> change slightly depending on the branch dealt with.
+1. I think that makes backpatching easier.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
