Re: pgsql: psql: initialize comment-begin setting to a useful value by defa - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: psql: initialize comment-begin setting to a useful value by defa
Date
Msg-id YahtXUVtBeh+P7oL@paquier.xyz
Whole thread Raw
In response to pgsql: psql: initialize comment-begin setting to a useful value by defa  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: psql: initialize comment-begin setting to a useful value by defa  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Hi Tom,

On Wed, Dec 01, 2021 at 05:24:58PM +0000, Tom Lane wrote:
> psql: initialize comment-begin setting to a useful value by default.
>
> Readline's meta-# command is supposed to insert a comment marker
> at the start of the current line.  However, the default marker is
> "#" which is entirely unhelpful for SQL.  Set it to "-- " instead.
> (This setting can still be overridden in one's ~/.inputrc file,
> so this change won't affect people who have already taken steps
> to make the command useful.)

prairiedog is unhappy after this commit due to the use of
rl_variable_bind():
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prairiedog&dt=2021-12-02%2005%3A29%3A32

/usr/bin/ld: Undefined symbols:
_rl_variable_bind
collect2: ld returned 1 exit status

Thanks,
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: pg_waldump: Emit stats summary when interrupted by SIGINT
Next
From: Peter Eisentraut
Date:
Subject: pgsql: pg_dump: Add missing relkind case