More business with $Test::Builder::Level in the TAP tests - Mailing list pgsql-hackers

From Michael Paquier
Subject More business with $Test::Builder::Level in the TAP tests
Date
Msg-id YV1CCFwgM1RV1LeS@paquier.xyz
Whole thread Raw
Responses Re: More business with $Test::Builder::Level in the TAP tests  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Re: More business with $Test::Builder::Level in the TAP tests  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Hi all,

Following up with Peter E's recent commit 73aa5e0 to add some
forgotten level incrementations, I got to look again at what I did
wrong and why this stuff is useful.

I have gone through all the TAP tests and any code paths using
subroutines, to note that we could improve the locations of the
reports we get by adding more $Test::Builder::Level.  The context is
important, as some code paths use rather-long routines and also
argument values that allow to track easily which test path is being
taken (like pg_rewind), so there is no need to add anything in such
places.  The attached patch adds incrementations for the tests where
the debugging becomes much easier if there is a failure.

Thoughts?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: BUG #17212: pg_amcheck fails on checking temporary relations
Next
From: Peter Geoghegan
Date:
Subject: Re: wrapping CF 2021-09