Re: More business with $Test::Builder::Level in the TAP tests - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: More business with $Test::Builder::Level in the TAP tests
Date
Msg-id a9f99d81-e457-eb54-9b1e-8c4ba2fc33da@enterprisedb.com
Whole thread Raw
In response to More business with $Test::Builder::Level in the TAP tests  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 06.10.21 08:28, Michael Paquier wrote:
> Following up with Peter E's recent commit 73aa5e0 to add some
> forgotten level incrementations, I got to look again at what I did
> wrong and why this stuff is useful.
> 
> I have gone through all the TAP tests and any code paths using
> subroutines, to note that we could improve the locations of the
> reports we get by adding more $Test::Builder::Level.  The context is
> important, as some code paths use rather-long routines and also
> argument values that allow to track easily which test path is being
> taken (like pg_rewind), so there is no need to add anything in such
> places.  The attached patch adds incrementations for the tests where
> the debugging becomes much easier if there is a failure.

These look correct to me.




pgsql-hackers by date:

Previous
From: bt21tanigaway
Date:
Subject: Re: Fix pg_log_backend_memory_contexts() 's delay
Next
From: Etsuro Fujita
Date:
Subject: Re: RfC entries in CF 2021-09