Re: [PATCH] test/ssl: rework the sslfiles Makefile target - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] test/ssl: rework the sslfiles Makefile target
Date
Msg-id YTFwZcl6NMCmqifQ@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] test/ssl: rework the sslfiles Makefile target  (Jacob Champion <pchampion@vmware.com>)
Responses Re: [PATCH] test/ssl: rework the sslfiles Makefile target
List pgsql-hackers
On Thu, Sep 02, 2021 at 04:42:14PM +0000, Jacob Champion wrote:
> Done that way in v5. It's a lot of moved code, so I've kept it as two
> commits for review purposes.

Nice.  This is neat.  The split helps a lot to understand how you've
changed things from the original implementation.  As a whole, this
looks rather committable to me.

One small-ish comment that I have is about all the .config files we
have at the root of src/test/ssl/, bloating the whole.  I think that
it would be a bit cleaner to put all of them in a different
sub-directory, say just config/ or conf/.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] pg_ctl should not truncate command lines at 1024 characters
Next
From: Michael Paquier
Date:
Subject: Re: Estimating HugePages Requirements?