Re: [PATCH] test/ssl: rework the sslfiles Makefile target - Mailing list pgsql-hackers

From Jacob Champion
Subject Re: [PATCH] test/ssl: rework the sslfiles Makefile target
Date
Msg-id 20199146fd61b7ae4bb4251c1b0a8c8bc3dd5b6c.camel@vmware.com
Whole thread Raw
In response to Re: [PATCH] test/ssl: rework the sslfiles Makefile target  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] test/ssl: rework the sslfiles Makefile target  (Jacob Champion <pchampion@vmware.com>)
List pgsql-hackers
On Fri, 2021-09-03 at 09:46 +0900, Michael Paquier wrote:
> Nice.  This is neat.  The split helps a lot to understand how you've
> changed things from the original implementation.  As a whole, this
> looks rather committable to me.

Great!

> One small-ish comment that I have is about all the .config files we
> have at the root of src/test/ssl/, bloating the whole.  I think that
> it would be a bit cleaner to put all of them in a different
> sub-directory, say just config/ or conf/.

That sounds reasonable. I won't be able to get to it before the holiday
weekend, but I can put up a patch sometime next week.

Thanks,
--Jacob

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: A reloption for partitioned tables - parallel_workers
Next
From: Jacob Champion
Date:
Subject: Re: [PATCH] support tab-completion for single quote input with equal sign