Re: SI messages sent when excuting ROLLBACK PREPARED command - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: SI messages sent when excuting ROLLBACK PREPARED command
Date
Msg-id YRNqswLuKq67UbWO@paquier.xyz
Whole thread Raw
In response to RE: SI messages sent when excuting ROLLBACK PREPARED command  ("liuhuailing@fujitsu.com" <liuhuailing@fujitsu.com>)
Responses Re: SI messages sent when excuting ROLLBACK PREPARED command  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Tue, Aug 03, 2021 at 09:29:48AM +0000, liuhuailing@fujitsu.com wrote:
> There was a problem with the before patch when testing.
> So resubmit it.

FWIW, I see no problems with patch version 1 or 2, as long as you
apply patch version 1 with a command like patch -p2.  One thing of
patch 2 is that git diff --check complains because of a whitespace.

Anyway, I also think that you are right here and that there is no need
to run this code path with ROLLBACK PREPARED.  It is worth noting that
the point of Tom about local invalidation messages in PREPARE comes
from PostPrepare_Inval().

I would just tweak the comment block at the top of what's being
changed, as per the attached.  Please let me know if there are any
objections.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Added schema level support for publication.
Next
From: Amit Kapila
Date:
Subject: Re: Unresolved repliaction hang and stop problem.