RE: SI messages sent when excuting ROLLBACK PREPARED command - Mailing list pgsql-hackers

From liuhuailing@fujitsu.com
Subject RE: SI messages sent when excuting ROLLBACK PREPARED command
Date
Msg-id OSZPR01MB62150130DBCBBFA833FFE239BEF09@OSZPR01MB6215.jpnprd01.prod.outlook.com
Whole thread Raw
In response to RE: SI messages sent when excuting ROLLBACK PREPARED command  ("liuhuailing@fujitsu.com" <liuhuailing@fujitsu.com>)
Responses Re: SI messages sent when excuting ROLLBACK PREPARED command  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
 Hi, tom

> >Hmmm, yeah, I think you're right.  It probably doesn't make a big difference in
> the real world --- anyone who's dependent on the performance of 2PC rollbaxks
> is Doing It Wrong.
> > But we'd have already done LocalExecuteInvalidationMessage when getting
> out of the prepared transaction, so no other SI invals should be needed.
> Yes, it does not make any error.
> 
> But for the beginner,  when understanding the code,  it may make confused.
> And for the developer, when developing based on this code, it may make
> unnecessary handling added.
> 
> So, I think it is better to optimize the code.
> 
> Here is the patch.
There was a problem with the before patch when testing.  
So resubmit it.

Regards, Liu Huailing


Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Failed transaction statistics to measure the logical replication progress
Next
From: "Andrey V. Lepikhov"
Date:
Subject: Extra code in commit_ts.h