Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
Date
Msg-id YOzy2rlluWYYoUvW@paquier.xyz
Whole thread Raw
In response to Bogus HAVE_DECL_FOO entries in msvc/Solution.pm  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Jul 12, 2021 at 07:46:32PM -0400, Tom Lane wrote:
> Autoconf's AC_CHECK_DECLS always defines HAVE_DECL_whatever
> as 1 or 0, but some of the entries in msvc/Solution.pm show
> such symbols as "undef" instead.  Shouldn't we fix it as
> per attached?  This is probably only cosmetic at the moment,
> but it could bite us someday if someone wrote a complex
> conditional using one of these symbols.

Hmm.  I have not tested, but agreed that this is inconsistent.  I
would tend to vote for a backpatch to keep some consistency across the
branches as changes in this area could easily lead to rather conflicts
harder to parse.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: O_DIRECT on macOS
Next
From: David Rowley
Date:
Subject: Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values