Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values - Mailing list pgsql-hackers

From David Rowley
Subject Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values
Date
Msg-id CAApHDvr=eKFBzuL5e_0DBpN5sUuNE-dGq+vZ-t=K+6MCZatCXg@mail.gmail.com
Whole thread Raw
In response to Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
On Tue, 13 Jul 2021 at 06:50, Peter Eisentraut
<peter.eisentraut@enterprisedb.com> wrote:
> Your version looks better to me than the original version, but I'm still
> -0.05 on changing this at all.

I was more +0.4.  It does not seem worth the trouble of too much
discussion so, just to try and bring this to a close, instead of
adding a comment to explain why we needlessly check the range of the
INT8 sequence, I just pushed the patch that removes it and adds the 1
line comment to mention why it's not needed.

David



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
Next
From: Jeff Davis
Date:
Subject: Re: Synchronous commit behavior during network outage