Re: More time spending with "delete pending" - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: More time spending with "delete pending"
Date
Msg-id YOvYnj2pB/EB2l8A@paquier.xyz
Whole thread Raw
In response to Re: More time spending with "delete pending"  (Michael Paquier <michael@paquier.xyz>)
Responses Re: More time spending with "delete pending"  (Alexander Lakhin <exclusion@gmail.com>)
Re: More time spending with "delete pending"  (Alexander Lakhin <exclusion@gmail.com>)
List pgsql-hackers
On Mon, Jul 12, 2021 at 02:09:41PM +0900, Michael Paquier wrote:
> And fairywren, that uses MinGW, is unhappy:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2021-07-12%2004%3A47%3A13
> Looking at it now.

I am not sure what to do here to cool down MinGW, so the patch has
been reverted for now:
- Plain stat() is not enough to do a proper detection of the files
pending for deletion on MSVC, so reverting only the part with
microsoft_native_stat() is not going to help.
- We are going to need an evaluation of the stat() implementation in
MinGW and check if is it possible to rely on it more.  If yes, we
could get away with more tweaks based on __MINGW32__/__MINGW64__.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Skipping logical replication transactions on subscriber side
Next
From: Michael Paquier
Date:
Subject: Re: Teach pg_receivewal to use lz4 compression