Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Pull general SASL framework out of SCRAM - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Pull general SASL framework out of SCRAM
Date
Msg-id YOpwhZFOpC0UUQaB@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Pull general SASL framework out of SCRAM  (Jacob Champion <pchampion@vmware.com>)
Responses Re: [PATCH] Pull general SASL framework out of SCRAM
List pgsql-hackers
Tree view 
On Fri, Jul 09, 2021 at 11:31:48PM +0000, Jacob Champion wrote:
> On Thu, 2021-07-08 at 16:27 +0900, Michael Paquier wrote:
>> +     *    outputlen: The length (0 or higher) of the client response buffer,
>> +     *               invalid if output is NULL.
>
> nitpick: maybe "ignored" instead of "invalid"?

Thanks, applied as 44bd012 after using your suggestion.

Another thing I noticed after more review is that the check in
fe-auth.c to make sure that a message needs to be generated if the
exchange is not completed yet has no need to depend on "success", only
"done".
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: unnesting multirange data types
Next
From: Thomas Munro
Date:
Subject: Re: pgbench logging broken by time logic changes