Re: [PATCH] Pull general SASL framework out of SCRAM - Mailing list pgsql-hackers

From Jacob Champion
Subject Re: [PATCH] Pull general SASL framework out of SCRAM
Date
Msg-id 5a75d91c1e06cce43ba038ccaa8bfded5cb35df2.camel@vmware.com
Whole thread Raw
In response to Re: [PATCH] Pull general SASL framework out of SCRAM  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] Pull general SASL framework out of SCRAM  (Michael Paquier <michael@paquier.xyz>)
RE: [PATCH] Pull general SASL framework out of SCRAM  ("Mikhail Kulagin" <m.kulagin@postgrespro.ru>)
List pgsql-hackers
On Thu, 2021-07-08 at 16:27 +0900, Michael Paquier wrote:
> I agree that this looks like an improvement in terms of the
> expectations behind a SASL mechanism, so I have done the attached to
> strengthen a bit all those checks.  However, I don't really see a
> point in back-patching any of that, as SCRAM satisfies with its
> implementation already all those conditions AFAIK.

Agreed.

> Thoughts?

LGTM, thanks!

> +     *    outputlen: The length (0 or higher) of the client response buffer,
> +     *               invalid if output is NULL.

nitpick: maybe "ignored" instead of "invalid"?

--Jacob

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: pg_dump new feature: exporting functions only. Bad or good idea ?
Next
From: Tom Lane
Date:
Subject: Re: pg_dump new feature: exporting functions only. Bad or good idea ?