Re: Different compression methods for FPI - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Different compression methods for FPI
Date
Msg-id YNl8CqZfArWqXbJ8@paquier.xyz
Whole thread Raw
In response to Re: Different compression methods for FPI  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: Different compression methods for FPI
Re: Different compression methods for FPI
List pgsql-hackers
On Sat, Jun 26, 2021 at 06:11:26PM -0500, Justin Pryzby wrote:
> Curious.  I found that before a4d75c86bf, there was an issue without the
> "extra" patches.

Is this issue different than the XID problem not matching when using
wal_level = minimal in test 011_crash_recovery.pl?  I am not sure to
understand if you are

> I have no idea why that patch changes the behavior, but before a4d7, this patch
> series failed like:

Not seeing the link here.  011_crash_recovery.pl has nothing to do
with extended statistics, normally.

> I think Andrey has been saying that since this already fails with PGLZ wal
> compression, we could consider this to be a pre-existing problem.  I'm not
> thrilled with that interpretation, but it's not wrong.

Removing "allows_streaming => 1" in 011_crash_recovery.pl is enough to
make the test fail on HEAD.  And the test fails equally without or
without any changes related to wal_compression, so adding or removing
options to wal_compression is not going to change anything with that.
There is simply no relationship I can spot, though I may be missing of
course an argument here.  Let's just discuss this recovery issue where
it should be discussed (these are patches 0002 and 0003 in the patch
v9 sent upthread):
https://www.postgresql.org/message-id/20210308.173242.463790587797836129.horikyota.ntt%40gmail.com
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: What is "wraparound failure", really?
Next
From: Michael Paquier
Date:
Subject: Re: Preventing abort() and exit() calls in libpq