On Mon, Feb 15, 2021 at 02:15:51PM +1300, Thomas Munro wrote:
> guc.c: In function ‘RestoreGUCState’:
> guc.c:9455:4: error: ‘varsourceline’ may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
> 9455 | set_config_sourcefile(varname, varsourcefile, varsourceline);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> I propose the attached.
We usually don't bother much about compilation warnings in stable
branches as long as they are not real bugs, and these are the oldest
stable ones. So why here? I would have patched the top of the
function if it were me, btw.
--
Michael
