Re: Possible dereference null return (src/backend/replication/logical/reorderbuffer.c) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Possible dereference null return (src/backend/replication/logical/reorderbuffer.c)
Date
Msg-id YCc8FzswlSvC8WLE@paquier.xyz
Whole thread Raw
In response to Re: Possible dereference null return (src/backend/replication/logical/reorderbuffer.c)  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: Possible dereference null return (src/backend/replication/logical/reorderbuffer.c)
List pgsql-hackers
On Fri, Feb 12, 2021 at 03:56:02PM +0900, Kyotaro Horiguchi wrote:
> If the return from the first call is a subtransaction, the second call
> always obtain the top transaction.  If the top transaction actualy did
> not exist, it's rather the correct behavior to cause SEGV, than
> creating a bogus rbtxn. THus it is wrong to set create=true and
> create_as_top=true.  We could change the assertion like Assert (txn &&
> txn->base_snapshot) to make things clearer.

I don't see much the point to change this code.  The result would be
the same: a PANIC at this location.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Tightening up allowed custom GUC names
Next
From: Michael Paquier
Date:
Subject: Re: [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses