Postgres Pro
Downloads
Home   >   mailing lists

Re: [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses
Date
Msg-id YCc/A3BFNmzi4gBK@paquier.xyz
Whole thread Raw
In response to [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses  (Ian Lawrence Barwick <barwick@gmail.com>)
Responses Re: [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses
Re: [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses
List pgsql-hackers
Tree view 
On Fri, Feb 12, 2021 at 10:32:14AM +0900, Ian Lawrence Barwick wrote:
> In the documentation, the "[ NO ]" option is listed in the synopsis for
> ALTER TRIGGER and ALTER FUNCTION, but not the others.
> Trivial patch attached.

There are two flavors to cover for 6 commands per gram.y, and you are
covering all of them.  So this looks good to me.  I'll apply and
backpatch in a bit.  It is worth noting that tab-complete.c does a bad
job in completing those clauses.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Possible dereference null return (src/backend/replication/logical/reorderbuffer.c)
Next
From: Masahiko Sawada
Date:
Subject: Re: [PoC] Non-volatile WAL buffer